[Resolve #1482] Make shell optional in cmd hook #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now you can set the command to run as an object without also having to set the shell. In this case it uses the default shell, as if the command to run were passed as a string. This allows you to use resolvers to set the command without worrying about which shell to invoke. See @dmarra's use case in Sceptre#1482.
|
Whats the story with this PR? I noticed it doesn't have a reviewer; is that why it hasn't been merged yet? |
|
@dan-marra-ebrs , @dmarra, Sorry, I don't know who is reviewing these PRs today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now you can set the command to run as an object without also having to set the shell.
In this case it uses the default shell, as if the command to run were passed as a string.
This allows you to use resolvers to set the command without worrying about which shell to invoke. See @dmarra's use case in #1482.
[Your PR description here]
PR Checklist
[Resolve #issue-number].poetry run tox) are passing.poetry run pre-commit run --all-files).and description in grammatically correct, complete sentences.
Approver/Reviewer Checklist
Other Information
Guide to writing a good commit